Add "Star on GitHub" banner in navbar #4
Merged
+262
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mishushakov
requested changes
Jan 18, 2025
There was a problem hiding this comment.
Points:
- Remove animations when you hover over the star button, users might find it annoying.
- Remove the star count to reduce mental overhead reading the code-base (remember this is an example project)
- Adjust font size of the button (looks kinda small now) and the colour (too light, blind people may not recognise the text)
- For some reason the layout of the app changed - suggestions moved to bottom of the chat input, before they were at the top and I am also experiencing double-scroll on Safari. Can you revert this and only apply changes to the navbar component?
- The y padding of the navbar now needs to be reduced, since the button takes a lot of vertical space - aim to keep the navbar height similar as before.
Thank you ;)
mishushakov
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr applies the following:
RepoBannercomponent in navbar